Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataCatalog2.0]: Move pattern resolution logic - catalog cli #4130

Conversation

ElenaKhaustova
Copy link
Contributor

@ElenaKhaustova ElenaKhaustova commented Aug 29, 2024

Description

This PR is a part of #4110 and is done on top of #4124

It serves as an example of changes required to keep both implementations together so that users can switch between them and use both, see the related comment

For the reviewers: this PR does not include tests, please see the suggested order of work in this comment

Development notes

This PR includes modification of kedro catalog commands - list, create, rank and resolve to be compatible with KedroDataCatalog and DataCatalogConfigResolver.

Currently, one can use old DataCatalog as usual without any changes or use KedroDataCatalog with kedro catalog [command] by adding --new_catalog or -n flag:

kedro catalog resolve -n
kedro catalog rank --new_catalog

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
…10-move-pattern-resolution-logic-catalog-cli
…10-move-pattern-resolution-logic-catalog-cli
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
@ElenaKhaustova ElenaKhaustova changed the title Move pattern resolution logic catalog cli [DataCatalog2.0]: Move pattern resolution logic - catalog cli Aug 29, 2024
@ElenaKhaustova ElenaKhaustova marked this pull request as ready for review August 29, 2024 22:09
…10-move-pattern-resolution-logic-catalog-cli
@ElenaKhaustova
Copy link
Contributor Author

Replaced with #4123 and #4151

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant