Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc/slicing pipeline kedro viz #4144

Merged
merged 5 commits into from
Sep 20, 2024
Merged

Conversation

Huongg
Copy link
Contributor

@Huongg Huongg commented Sep 5, 2024

Description

As part of the slicing pipeline feature in Kedro-Viz, I've added a section in the Kedro documentation under 'Slice a Pipeline' to briefly demonstrate how users can achieve the same functionality and a link to Kedro-Viz doc

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

Huong Nguyen added 2 commits August 19, 2024 16:44
Signed-off-by: Huong Nguyen <huongg1409@gmail>
Signed-off-by: Huong Nguyen <huongg1409@gmail>
@astrojuanlu
Copy link
Member

sphinx.errors.SphinxWarning: /home/docs/checkouts/readthedocs.org/user_builds/kedro/checkouts/4144/docs/source/nodes_and_pipelines/slice_a_pipeline.md:6:broken link: https://docs.kedro.org/projects/kedro-viz/en/stable/slice_a_pipeline.html (404 Client Error: Not Found for url: https://docs.kedro.org/projects/kedro-viz/en/stable/slice_a_pipeline.html)

Doc will give 404 until Viz makes a release

Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Huongg Huongg requested a review from merelcht September 6, 2024 08:30
Copy link
Member

@merelcht merelcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! I'm very excited for this feature 🤩

merelcht and others added 2 commits September 20, 2024 11:41
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
@merelcht
Copy link
Member

@Huongg I'll merge this now all checks are passing!

@merelcht merelcht merged commit 82a69f2 into main Sep 20, 2024
10 checks passed
@merelcht merelcht deleted the doc/slicing-pipeline-kedro-viz branch September 20, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants