-
Notifications
You must be signed in to change notification settings - Fork 901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix template projects example tests #4159
Conversation
Signed-off-by: Janne Holopainen <manezki@gmail.com>
Signed-off-by: Janne Holopainen <manezki@gmail.com>
Signed-off-by: Janne Holopainen <manezki@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much @Manezki ! 🌟 I can't believe we didn't spot that earlier 🙈
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Manezki!
Thanks for the snappy review (and the positive comments). I don't have permission to merge the PR. Is there still something I should do?
|
No, I can merge it for you 👍 For the remaining "open points" I have the following:
This is more a suggestion, but in this case we can ignore it.
Indeed, no impact on Viz for this change.
No need for that. Thanks again for the contribution! |
Description
New project created by
kedro new --tools test
has example test that does not work.Development notes
After the changes a new project can successfully run tests with
pytest .
Checklist
RELEASE.md
file