Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix template projects example tests #4159

Merged
merged 3 commits into from
Sep 16, 2024
Merged

Fix template projects example tests #4159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
722afd0
Fix: Switch ConfigLoader to OmegaConfigLoader
Manezki Sep 12, 2024
b5caee4
Fix: Add env to KedroContext
Manezki Sep 12, 2024
94f42c5
Doc: Add changes to RELEASE.md
Manezki Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions RELEASE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
* Enhanced `OmegaConfigLoader` configuration validation to detect duplicate keys at all parameter levels, ensuring comprehensive nested key checking.
## Bug fixes and other changes
* Fixed bug where using dataset factories breaks with `ThreadRunner`.
* Fixed template projects example tests.

## Breaking changes to the API
* Removed `ShelveStore` to address a security vulnerability.
Expand All @@ -18,6 +19,7 @@
## Community contributions
* [Puneet](https://github.com/puneeter)
* [ethanknights](https://github.com/ethanknights)
* [Manezki](https://github.com/Manezki)

Check warning on line 22 in RELEASE.md

View workflow job for this annotation

GitHub Actions / runner / vale 

[vale] reported by reviewdog 🐶
[Kedro.Spellings] Did you really mean 'Manezki'?

Raw Output:
{"message": "[Kedro.Spellings] Did you really mean 'Manezki'?", "location": {"path": "RELEASE.md", "range": {"start": {"line": 22, "column": 4}}}, "severity": "WARNING"}

# Release 0.19.8

Expand Down
5 changes: 3 additions & 2 deletions kedro/templates/project/{{ cookiecutter.repo_name }}/tests/test_run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,22 +12,23 @@

import pytest

from kedro.config import ConfigLoader
from kedro.config import OmegaConfigLoader
from kedro.framework.context import KedroContext
from kedro.framework.hooks import _create_hook_manager
from kedro.framework.project import settings


@pytest.fixture
def config_loader():
return ConfigLoader(conf_source=str(Path.cwd() / settings.CONF_SOURCE))
return OmegaConfigLoader(conf_source=str(Path.cwd() / settings.CONF_SOURCE))


@pytest.fixture
def project_context(config_loader):
return KedroContext(
package_name="{{ cookiecutter.python_package }}",
project_path=Path.cwd(),
env="local",
config_loader=config_loader,
hook_manager=_create_hook_manager(),
)
Expand Down
Loading