Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SparkHook configuration loading line on docs. #4194

Merged
merged 3 commits into from
Sep 26, 2024

Conversation

lrcouto
Copy link
Contributor

@lrcouto lrcouto commented Sep 25, 2024

Description

#4118 and #4166 pointed out that the way our documentation instructs users to load the spark.yml config file might be incorrect. The changed line should work, assuming that the file is at conf/base/spark.yml.

Development notes

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

Signed-off-by: Laura Couto <laurarccouto@gmail.com>
@lrcouto lrcouto linked an issue Sep 25, 2024 that may be closed by this pull request
@lrcouto lrcouto changed the title Alter spark config load line on docs Update SparkHook configuration loading line on docs. Sep 25, 2024
@lrcouto lrcouto marked this pull request as ready for review September 25, 2024 15:20
Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I don't have time to QA this at the moment, consider requesting reviews from the rest of the team!

lrcouto and others added 2 commits September 26, 2024 13:58
Signed-off-by: Laura Couto <laurarccouto@gmail.com>
@lrcouto lrcouto merged commit f1d3751 into main Sep 26, 2024
10 checks passed
@lrcouto lrcouto deleted the update-sparkhook-doc branch September 26, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation for SparkHook needs updating to v19
3 participants