Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KedroDataCatalog release updates #4214

Merged
merged 5 commits into from
Oct 8, 2024

Conversation

ElenaKhaustova
Copy link
Contributor

@ElenaKhaustova ElenaKhaustova commented Oct 7, 2024

Description

Context: https://github.com/orgs/kedro-org/projects/2/views/4?pane=issue&itemId=81553599

Development notes

  1. Updated release notes, module and class docstrings with the clarification about future possible breaking changes and added usage example.
  2. Removed previously added add_data() method as it was considered as odd when working on [DataCatalog2.0]: Extend KedroDataCatalog with dict interface #4175,
    def add_data(self, data: dict[str, Any], replace: bool = False) -> None:

    So it was decided not to introduce it.

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
…note

Signed-off-by: Elena Khaustova <ymax70rus@gmail.com>
@ElenaKhaustova ElenaKhaustova marked this pull request as ready for review October 7, 2024 18:21
Copy link
Contributor

@lrcouto lrcouto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@merelcht merelcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small adjustments to wording, but otherwise looks good 👍

RELEASE.md Outdated Show resolved Hide resolved
kedro/io/kedro_data_catalog.py Outdated Show resolved Hide resolved
ElenaKhaustova and others added 3 commits October 8, 2024 14:46
Co-authored-by: Merel Theisen <49397448+merelcht@users.noreply.github.com>
Signed-off-by: ElenaKhaustova <157851531+ElenaKhaustova@users.noreply.github.com>
Co-authored-by: Merel Theisen <49397448+merelcht@users.noreply.github.com>
Signed-off-by: ElenaKhaustova <157851531+ElenaKhaustova@users.noreply.github.com>
@ElenaKhaustova ElenaKhaustova enabled auto-merge (squash) October 8, 2024 13:48
@ElenaKhaustova ElenaKhaustova changed the title KedroDataCatalog release updates KedroDataCatalog release updates Oct 8, 2024
@ElenaKhaustova ElenaKhaustova merged commit 6adbed9 into main Oct 8, 2024
34 checks passed
@ElenaKhaustova ElenaKhaustova deleted the kedro-data-catalog-release-updates branch October 8, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants