Add benchmarks for KedroDataCatalog and fix tests for DataCatalog
#4246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
noklam
approved these changes
Oct 21, 2024
merelcht
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
Thank you, @ankatiyar!
Added some suggestions on extending tests.
| def time_setitem(self): | ||
| """Benchmark the time to set a dataset""" | ||
| for i in range(1,1001): | ||
| self.catalog[f"dataset_new_{i}"] = CSVDataset(filepath="data.csv") |
There was a problem hiding this comment.
Can we please also add setting raw data? So this part of setter was covered:
kedro/kedro/io/kedro_data_catalog.py
Line 137 in 3818a2a
There was a problem hiding this comment.
Added a separate test for this
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
Signed-off-by: Ankita Katiyar <ankitakatiyar2401@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Close #4125
Development notes
KedroDataCatalogDataCatalog: The tests were failing forDataCatalog.add_feed_dict()andDataCatalog.add_all()because asv runs thesetup()then repeats the tests for a number of times and then runsteardown()but trying to add the same datasets multiple times results inDatasetAlreadyExistsErrorhttps://github.com/kedro-org/kedro/actions/workflows/benchmark-performance.ymlTo test locally:
asv runDeveloper Certificate of Origin
We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a
Signed-off-byline in the commit message. See our wiki for guidance.If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.
Checklist
RELEASE.mdfile