Merge pull request #21 from Akashneelesh/project-file-structuring

Added issues
keep-starknet-strange · May 28, 2024 · a0d8964 · a0d8964
2 parents 20d7489 + f1d66e5
commit a0d8964
Showing 1 changed file with 94 additions and 3 deletions.
diff --git a/src/core/registry.cairo b/src/core/registry.cairo
@@ -42,18 +42,109 @@ pub mod Registry {
 
 
     #[constructor]
-    fn constructor(ref self: ContractState) {}
+    fn constructor(ref self: ContractState) { // Issue no #19
+    // https://github.com/allo-protocol/allo-v2/blob/4dd0ea34a504a16ac90e80f49a5570b8be9b30e9/contracts/core/Registry.sol#L78C40-L79C9
+    // Implement the functionality of making sure the address is not zero and
+    // grant the Allo owner role to the owner.
+    // You can use the posiedon hashing for hasing storing Allo owner
+    }
 
 
     /// ====================================
     /// ==== External/Public Functions =====
     /// ====================================
     #[abi(embed_v0)]
-    impl Registry of super::IRegistry<ContractState> {}
+    impl Registry of super::IRegistry<
+        ContractState
+    > { // Issue no. #15 Implement the functionality to retrieve profile by profileId
+    // Down below is the function that is to be implemented in the contract but in cairo.
+    // https://github.com/allo-protocol/allo-v2/blob/4dd0ea34a504a16ac90e80f49a5570b8be9b30e9/contracts/core/Registry.sol#L94
+    // Use _profileID as u256 
+
+    // Issue no. #14 Implement the functionality to retrieve profile by anchor
+    // Down below is the function that is to be implemented in the contract but in cairo.
+    // https://github.com/allo-protocol/allo-v2/blob/4dd0ea34a504a16ac90e80f49a5570b8be9b30e9/contracts/core/Registry.sol#L102
+
+    // Issue no. #13 Implement the functionality of createProfile
+    // Down below is the function that is to be implemented in the contract but in cairo.
+    // https://github.com/allo-protocol/allo-v2/blob/4dd0ea34a504a16ac90e80f49a5570b8be9b30e9/contracts/core/Registry.sol#L118C5-L125C18
+
+    // Issue no. #12 Implement the functionality of updateProfileName
+    // Down below is the function that is to be implemented in the contract but in cairo.
+    // https://github.com/allo-protocol/allo-v2/blob/4dd0ea34a504a16ac90e80f49a5570b8be9b30e9/contracts/core/Registry.sol#L182C14-L182C31
+
+    // Issue no. #11 Implement the functionality of updateProfileMetadata
+    // Down below is the function that is to be implemented in the contract but in cairo.
+    // https://github.com/allo-protocol/allo-v2/blob/4dd0ea34a504a16ac90e80f49a5570b8be9b30e9/contracts/core/Registry.sol#L214C14-L214C35
+
+    // Issue no. #10 Implement the functionality of isOwnerOrMemberOfProfile
+    // Use u256 instead of bytes32
+    // Down below is the function that is to be implemented in the contract but in cairo.
+    // https://github.com/allo-protocol/allo-v2/blob/4dd0ea34a504a16ac90e80f49a5570b8be9b30e9/contracts/core/Registry.sol#L229
+
+    // Issue no. #3 Implement the functionality of isOwnerOfProfile
+    // Down below is the function that is to be implemented in the contract but in cairo.
+    // https://github.com/allo-protocol/allo-v2/blob/4dd0ea34a504a16ac90e80f49a5570b8be9b30e9/contracts/core/Registry.sol#L245
+
+    // Issue no. #5 Implement the functionality of isMemberOfProfile
+    // Down below is the function that is to be implemented in the contract but in cairo.
+    // https://github.com/allo-protocol/allo-v2/blob/4dd0ea34a504a16ac90e80f49a5570b8be9b30e9/contracts/core/Registry.sol#L245
+
+    // Issue no. #9 Implement the functionality of UpdateProfilePendingOwner
+    // Down below is the function that is to be implemented in the contract but in cairo.
+    // https://github.com/allo-protocol/allo-v2/blob/4dd0ea34a504a16ac90e80f49a5570b8be9b30e9/contracts/core/Registry.sol#L253
+
+    // Issue no. #8 Implement the functionality of acceptProfileOwnership
+    // Down below is the function that is to be implemented in the contract but in cairo.
+    // https://github.com/allo-protocol/allo-v2/blob/4dd0ea34a504a16ac90e80f49a5570b8be9b30e9/contracts/core/Registry.sol#L267
+
+    // Issue no. #7 Implement the functionality of addMembers
+    // Use u256 instead of bytes32
+    // Down below is the function that is to be implemented in the contract but in cairo.
+    // https://github.com/allo-protocol/allo-v2/blob/4dd0ea34a504a16ac90e80f49a5570b8be9b30e9/contracts/core/Registry.sol#L289
+
+    // Issue no. #6 Implement the functionality of removeMembers
+    // Use u256 instead of bytes32
+    // Down below is the function that is to be implemented in the contract but in cairo.
+    // https://github.com/allo-protocol/allo-v2/blob/4dd0ea34a504a16ac90e80f49a5570b8be9b30e9/contracts/core/Registry.sol#L311
+
+    // Issue no. #16 Implement the functionality of recoverFunds
+    // Down below is the function that is to be implemented in the contract but in cairo.
+    // https://github.com/allo-protocol/allo-v2/blob/4dd0ea34a504a16ac90e80f49a5570b8be9b30e9/contracts/core/Registry.sol#L392C14-L392C26
+
+    }
 
     /// ====================================
     /// ==== Internal Functions ============
     /// ====================================
     #[generate_trait]
-    impl RegistryInternalImpl of RegistryInternalTrait {}
+    impl RegistryInternalImpl of RegistryInternalTrait { // Issue no. #19 Implement the functionality of _generateProfileId
+    // Internal function to create a profile
+    // https://github.com/allo-protocol/allo-v2/blob/4dd0ea34a504a16ac90e80f49a5570b8be9b30e9/contracts/core/Registry.sol#L366
+    // Reference on how to implement keccak256(abi.encodePacked) 
+    // Solidity - https://github.com/celestiaorg/blobstream-contracts/blob/0b4bcf69d1ce96df000da7f95fba8c03aa15a45e/src/lib/tree/namespace/TreeHasher.sol#L33
+    // Cairo - https://github.com/keep-starknet-strange/blobstream-starknet/blob/b74777e5fb479e5b4aa5a1419135e0826343fc37/src/tree/namespace/hasher.cairo#L10
+    // More about it - https://github.com/keep-starknet-strange/alexandria/tree/main/src/encoding
+
+    // Issue no. #18 Implement the functionality of _generateAnchor
+    // Internal function to create a _generateAnchor
+    // https://github.com/allo-protocol/allo-v2/blob/4dd0ea34a504a16ac90e80f49a5570b8be9b30e9/contracts/core/Registry.sol#L340
+
+    // Issue no. #17 Implement the functionality of _checkOnlyProfileOwner
+    // Down below is the function that is to be implemented in the contract but in cairo.
+    // https://github.com/allo-protocol/allo-v2/blob/4dd0ea34a504a16ac90e80f49a5570b8be9b30e9/contracts/core/Registry.sol#L331
+
+    // Issue no. #4 Implement the functionality of _generateProfileId
+    // Down below is the function that is to be implemented in the contract but in cairo.
+    // https://github.com/allo-protocol/allo-v2/blob/4dd0ea34a504a16ac90e80f49a5570b8be9b30e9/contracts/core/Registry.sol#L375C14-L375C31
+
+    // Issue no. #3 Implement the functionality of _isOwnerOfProfile
+    // Down below is the function that is to be implemented in the contract but in cairo.
+    // https://github.com/allo-protocol/allo-v2/blob/4dd0ea34a504a16ac90e80f49a5570b8be9b30e9/contracts/core/Registry.sol#L375C14-L375C31
+
+    // Issue n. #5 Implement the functionality of _isMemberOfProfile
+    // Down below is the function that is to be implemented in the contract but in cairo.
+    // https://github.com/allo-protocol/allo-v2/blob/4dd0ea34a504a16ac90e80f49a5570b8be9b30e9/contracts/core/Registry.sol#L384C14-L384C32
+
+    }
 }