ci: install binary in gh action #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-roak
reviewed
Sep 22, 2023
.github/actions/action.yml
Outdated
| @@ -10,7 +10,9 @@ inputs: | |||
| runs: | |||
| using: "composite" | |||
| steps: | |||
| - run: cargo build --release | |||
| - run: wget https://github.com/keep-starknet-strange/gomu-gomu-no-gatling/releases/download/v0.0.2-1-alpha/x86_64-unknown-linux-gnu-gatling -O gatling | |||
| shell: bash | |||
There was a problem hiding this comment.
Why do we need to specify the shell (this also applies to the other cases)?
There was a problem hiding this comment.
in my head it was a standard, prob not then
There was a problem hiding this comment.
let's remove it. It only makes sense to add it if we are using windows images and we want to use bash instead of powershell
d-roak
approved these changes
Sep 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installing binary in action in order to use over at Madara workflow