Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: install binary in gh action #15

Merged
merged 2 commits into from
Sep 22, 2023
Merged

ci: install binary in gh action #15

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
663aaad
ci: install binary in gh action
dbejarano820 Sep 22, 2023
51d2688
bash removal
dbejarano820 Sep 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/actions/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,9 @@ inputs:
runs:
using: "composite"
steps:
- run: cargo build --release
- run: wget https://github.com/keep-starknet-strange/gomu-gomu-no-gatling/releases/download/v0.0.2-1-alpha/x86_64-unknown-linux-gnu-gatling -O gatling
shell: bash
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to specify the shell (this also applies to the other cases)?

Copy link
Contributor Author

@dbejarano820 dbejarano820 Sep 22, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in my head it was a standard, prob not then

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's remove it. It only makes sense to add it if we are using windows images and we want to use bash instead of powershell

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

- run: ./target/release/gatling shoot --c ${{ inputs.config_path }}
- run: chmod +x gatling
d-roak marked this conversation as resolved.
Show resolved Hide resolved
shell: bash
- run: ./gatling shoot --c ${{ inputs.config_path }}
shell: bash