✨ Cairo 1 Validation #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #7 #18 #19
This PR adds full support for
v2.1.0config.It also adds multi-threaded validation of transactions which drastically speeds up the process. Note that we limit to 95 tasks because Madara prevents more than 100 simultaneous connections.
It also moves transactions' validation after building reports to not skew results.
It also fixes few bugs and cleans some code.
Next step will be adding multi-threading to send transactions. Weirdly, Cairo 1 accounts are like 10x slower than Cairo 0 accounts to send transactions which I haven't understood why yet. It could come from the execution encoding in
starknet-rswhich is the only thing that really changes apart from the class hash.