Add reporting to goose shoot and improve error handling #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Angel-Petrov
force-pushed
the
goose_reporting
branch
from
dcc297f
to
6c7edf8
Compare
Angel-Petrov
force-pushed
the
goose_reporting
branch
from
7448c01
to
adccd2f
Compare
Angel-Petrov
force-pushed
the
goose_reporting
branch
from
adccd2f
to
a79fc9e
Compare
EvolveArt
approved these changes
Mar 7, 2024
tdelabro
requested changes
Mar 8, 2024
tdelabro
approved these changes
Mar 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR now makes shoot write to a reporting file, with information like average TPS as well as how long it took for requests to be sent and how many requests failed. This PR also improves error handling so that failed requests are properly recorded instead of panicing the goose user. The PR has been updated with added instructions and the structure of the output.
An example of the report.json output is attached here.