Skip to content
This repository has been archived by the owner on Aug 2, 2024. It is now read-only.

bug: Invoking transaction on contract fails in newer madara versions #1539

Closed
Angel-Petrov opened this issue Mar 28, 2024 · 3 comments
Closed
Labels
bug Something isn't working

Comments

@Angel-Petrov
Copy link

Bug Report

Madara version:

194cf75 to latest in main

Current behavior:

When attempting to call starknet_addInvokeTransaction multiple times on a ERC20 contract the following errors occurs:

2024-03-28 10:09:09 Transaction execution failed during simulation: Invalid transaction nonce of contract at address ContractAddress(PatriciaKey(StarkFelt("0x025fdddd1a5a5c596d509e23118b5e1f5947fac246d8de43b3604f06ec9af5f9"))). Expected: Nonce(StarkFelt("0x0000000000000000000000000000000000000000000000000000000000000001")); got: Nonce(StarkFelt("0x00000000000000000000000000000000000000000000000000000000000000c8")).
2024-03-28 10:09:09 Failed to simulate User Transaction: PlaceHolderErrorTypeForFailedStarknetExecution

Similar errors also occur for other calls, like with minting in ERC721.

Expected behavior:

No issues should occur when invoking these transactions.

Steps to reproduce:

Calling multiple transations (including just two) on the same method on any contract should replicate this issue.
Here is a repository for a minimal example which replicates this issue: https://github.com/Angel-Petrov/Madara-Invoke-Bug

Related code:

This issue was originally found via gomu gomu.

@Angel-Petrov Angel-Petrov added the bug Something isn't working label Mar 28, 2024
@elielnfinic
Copy link
Contributor

If no body is working on this, I will be happy to work on this

@tdelabro
Copy link
Collaborator

tdelabro commented May 6, 2024

I think this is not true anymore, as gomu gomu is now running smoothly in the CI.
Can you confirm @Angel-Petrov ?

@Angel-Petrov
Copy link
Author

Angel-Petrov commented May 7, 2024

This can be closed now as this bug was fixed by another issue #1541

@github-actions github-actions bot locked and limited conversation to collaborators Jun 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants