Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeePassXC Installer should check VCredist Version #10974

Open
dvschuetz opened this issue Jun 25, 2024 · 7 comments
Open

KeePassXC Installer should check VCredist Version #10974

dvschuetz opened this issue Jun 25, 2024 · 7 comments

Comments

@dvschuetz
Copy link

Summary

On installing, the KeePassXC installer should check, whether the Visual C++ redistributable library is actual enough for the current KeePassXC version.

Actual Behaviour

The KeePassXC Installer checks, whether VC redist x64 is installed or not. (If not, ... I don't remember whether it just gives a message or leads to download VCredist.x64.) But if an older VCredist.x64 version is present, e.g. version 14.32.31326 of 2023, KeePassXC 2.7.9 will install, but not start and crash silently.

Examples

Bug #10925
Bug #10973

Context

Any computers with Windows 10 or 11 which installed KeePassXC the first time more than a year ago

@droidmonkey
Copy link
Member

droidmonkey commented Jun 25, 2024

Yes, can add but vcredist are supposed to be backwards compatible... this is ultimately a Microsoft bug

@droidmonkey
Copy link
Member

FWIW, a minimum version detection wound not have prevented or alerted people to this. For all we knew we were fully compatible with all versions of the msvc redist. Microsoft made no mention of an incompatibility and we didn't use any new api's between releases.

@rharmonson
Copy link

Not a complaint, but sharing my experience.

Just finished a fresh install of Windows 11 23H2 and all updates. KeePassXC 2.7.9 installs without issue, however, on launching, errors with three dialogs stating missing vcruntime140.dll and once for vcruntime140_1.dll.

Installed VC_redist.x64.exe and good to go.

Awesome application. Thank you.

@droidmonkey
Copy link
Member

droidmonkey commented Aug 21, 2024

Please share your experience with Microsoft, they need to deploy the vc redist with their operating system to make things better. We are looking at options, but MSI cannot install an MSI (which the vc redist is despite the exe suffix), another Microsoft limitation...

@rharmonson
Copy link

I agree. I will create a support ticket, but in my experience, Microsoft does not care unless you are a large commercial customer.

@rharmonson
Copy link

rharmonson commented Sep 11, 2024

https://developercommunity.visualstudio.com/t/Access-violation-in-_Thrd_yield-after-up/10664660#T-N10668856

Notice how they just put it on third party developers.

M$=A$$HAT$.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In progress
Development

No branches or pull requests

4 participants