-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: When workflow already executed. After controller restart, healthcheck could never be scheduled #236
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #236 +/- ##
==========================================
+ Coverage 67.99% 69.20% +1.21%
==========================================
Files 3 3
Lines 978 984 +6
==========================================
+ Hits 665 681 +16
+ Misses 232 223 -9
+ Partials 81 80 -1 ☔ View full report in Codecov by Sentry. |
…e scheduled Signed-off-by: Yu Jiang <yu_jiang@intuit.com>
Signed-off-by: Yu Jiang <yu_jiang@intuit.com>
Signed-off-by: Yu Jiang <yu_jiang@intuit.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fix: When workflow already executed. After reconcile and there's no reschedule handler, the healthcheck will never be executed.
Proposed Changes
Testing Done