Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GED 2023 Unit Tests (PR4) #102

Merged
merged 37 commits into from
Nov 17, 2023
Merged

GED 2023 Unit Tests (PR4) #102

merged 37 commits into from
Nov 17, 2023

Conversation

garomonegro
Copy link
Collaborator

@garomonegro garomonegro commented Jun 16, 2023

Improves Coverage by 22.25%. From 32.25% to 54.51%

@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (271d9ce) 31.56% compared to head (422d00a) 53.20%.

Files Patch % Lines
pkg/kube/structured/structured.go 68.57% 8 Missing and 3 partials ⚠️
pkg/kube/pod/pod.go 11.11% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #102       +/-   ##
===========================================
+ Coverage   31.56%   53.20%   +21.63%     
===========================================
  Files          12       12               
  Lines        1682     1669       -13     
===========================================
+ Hits          531      888      +357     
+ Misses       1070      674      -396     
- Partials       81      107       +26     
Flag Coverage Δ
unittests 53.20% <64.15%> (+21.63%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@garomonegro garomonegro force-pushed the GED-2023-PR4 branch 2 times, most recently from 3917695 to 4e3101e Compare June 17, 2023 01:00
garomonegro and others added 26 commits July 21, 2023 21:01
Signed-off-by: Alfredo Garo <44888596+garomonegro@users.noreply.github.com>
Signed-off-by: Alfredo Garo <44888596+garomonegro@users.noreply.github.com>
Signed-off-by: Alfredo Garo <44888596+garomonegro@users.noreply.github.com>
Signed-off-by: Alfredo Garo <44888596+garomonegro@users.noreply.github.com>
Signed-off-by: Alfredo Garo <44888596+garomonegro@users.noreply.github.com>
Signed-off-by: Alfredo Garo <44888596+garomonegro@users.noreply.github.com>
Signed-off-by: Alfredo Garo <44888596+garomonegro@users.noreply.github.com>
Signed-off-by: Alfredo Garo <44888596+garomonegro@users.noreply.github.com>
Signed-off-by: Alfredo Garo <44888596+garomonegro@users.noreply.github.com>
Signed-off-by: Alfredo Garo <44888596+garomonegro@users.noreply.github.com>
Signed-off-by: Alfredo Garo <44888596+garomonegro@users.noreply.github.com>
Signed-off-by: Alfredo Garo <44888596+garomonegro@users.noreply.github.com>
Signed-off-by: Alfredo Garo <44888596+garomonegro@users.noreply.github.com>
…sts & TestValidatePrometheusVolumeClaimTemplatesName
Alfredo Garo added 2 commits July 21, 2023 22:39
Signed-off-by: Alfredo Garo <garomonegro@Alfredos-MacBook-Pro.local>
@garomonegro garomonegro marked this pull request as ready for review July 22, 2023 02:49
Signed-off-by: Alfredo Garo <garomonegro@Alfredos-MacBook-Pro.local>
@garomonegro garomonegro marked this pull request as draft July 23, 2023 22:48
Alfredo Garo and others added 7 commits July 23, 2023 22:42
Signed-off-by: Alfredo Garo <garomonegro@Alfredos-MacBook-Pro.local>
Signed-off-by: Alfredo Garo <garomonegro@Alfredos-MacBook-Pro.local>
Signed-off-by: Alfredo Garo <garomonegro@Alfredos-MacBook-Pro.local>
Signed-off-by: Alfredo Garo <garomonegro@Alfredos-MacBook-Pro.local>
@garomonegro garomonegro marked this pull request as ready for review November 17, 2023 19:55
@garomonegro garomonegro requested review from a team as code owners November 17, 2023 19:55
Copy link
Member

@tekenstam tekenstam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tekenstam tekenstam merged commit 2e2f0b1 into master Nov 17, 2023
6 checks passed
@tekenstam tekenstam deleted the GED-2023-PR4 branch November 17, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants