Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add upsert operation #106

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Conversation

danielhelfand
Copy link
Contributor

Fixes #105

More details in the issue.

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Merging #106 (8e4f005) into master (7325567) will increase coverage by 0.39%.
The diff coverage is 62.50%.

@@            Coverage Diff             @@
##           master     #106      +/-   ##
==========================================
+ Coverage   31.86%   32.25%   +0.39%     
==========================================
  Files          12       12              
  Lines        1224     1240      +16     
==========================================
+ Hits          390      400      +10     
- Misses        756      760       +4     
- Partials       78       80       +2     
Flag Coverage Δ
unittests 32.25% <62.50%> (+0.39%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/kube/unstructured/unstructured.go 38.13% <62.50%> (+1.77%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Daniel Helfand <helfand.4@gmail.com>
@danielhelfand danielhelfand changed the title feat: update operation should create resource if it doesn't exist feat: add upsert operation Jul 21, 2023
@danielhelfand danielhelfand merged commit 447cf20 into keikoproj:master Jul 21, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Update Operations Idempotent
2 participants