feat: always log stdout from command #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielhelfand
force-pushed
the
log-cmd
branch
from
e948eca
to
5f50bd5
Compare
Codecov Report
@@ Coverage Diff @@
## master #107 +/- ##
==========================================
+ Coverage 32.25% 32.36% +0.10%
==========================================
Files 12 12
Lines 1240 1242 +2
==========================================
+ Hits 400 402 +2
Misses 760 760
Partials 80 80
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Daniel Helfand <helfand.4@gmail.com>
danielhelfand
force-pushed
the
log-cmd
branch
from
5f50bd5
to
970d152
Compare
garomonegro
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In scenarios when trying to debug tests that utilize a binary, it can be helpful to see all the output of the command. We should always show it regardless of success or failure of this step.