Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix for kdt.KubeClientSet.ResourceShouldConvergeToSelector #128

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

garomonegro
Copy link
Collaborator

No description provided.

@garomonegro garomonegro requested review from a team as code owners November 24, 2023 00:10
@garomonegro garomonegro requested a review from a team as a code owner November 24, 2023 00:12
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4173a54) 53.20% compared to head (460a3dd) 53.20%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #128   +/-   ##
=======================================
  Coverage   53.20%   53.20%           
=======================================
  Files          12       12           
  Lines        1669     1669           
=======================================
  Hits          888      888           
  Misses        674      674           
  Partials      107      107           
Flag Coverage Δ
unittests 53.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@kevdowney kevdowney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@garomonegro garomonegro merged commit bb3a5e1 into keikoproj:master Nov 27, 2023
5 checks passed
@garomonegro garomonegro deleted the bugfix branch November 27, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants