Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add configmap support #156

Merged
merged 3 commits into from
Jun 17, 2024
Merged

feat: add configmap support #156

merged 3 commits into from
Jun 17, 2024

Conversation

phanipadala
Copy link
Collaborator

  • Add function to validation configmap exists in desired namespace.
  • Add unit tests

@phanipadala phanipadala requested review from a team as code owners June 14, 2024 00:03
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 46.45%. Comparing base (5b5a76b) to head (b807b2c).

Current head b807b2c differs from pull request most recent head a7f9028

Please upload reports for the commit a7f9028 to get more accurate results.

Files Patch % Lines
kubedog.go 0.00% 2 Missing ⚠️
pkg/kube/kube.go 0.00% 2 Missing ⚠️
pkg/kube/structured/structured_helper.go 77.77% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #156      +/-   ##
==========================================
+ Coverage   45.80%   46.45%   +0.65%     
==========================================
  Files          19       19              
  Lines        1871     1890      +19     
==========================================
+ Hits          857      878      +21     
+ Misses        900      896       -4     
- Partials      114      116       +2     
Flag Coverage Δ
unittests 46.45% <70.00%> (+0.65%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Phanindra Padala <phanindra_padala@intuit.com>
Signed-off-by: Phanindra Padala <phanindra_padala@intuit.com>
@phanipadala phanipadala self-assigned this Jun 14, 2024
kubedog.go Outdated Show resolved Hide resolved
Signed-off-by: Phanindra Padala <phanindra_padala@intuit.com>
Copy link
Collaborator

@garomonegro garomonegro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@garomonegro garomonegro merged commit a68f911 into master Jun 17, 2024
6 checks passed
@garomonegro garomonegro deleted the add_configMap branch June 17, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants