Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent 0 batch size #348

Merged
merged 5 commits into from
Apr 21, 2024
Merged

Conversation

cspargo
Copy link
Contributor

@cspargo cspargo commented Nov 25, 2022

  • I swapped the order of these two clauses, because going by the comments, I think the intention is that the batch size should always be at least 1, however because the ASG size is 0, the batch size was getting set to 0
  • i have tested in our environment that this resolves the problem we were seeing and otherwise works as before
  • fixes upgrade never completes if ASG size is 0 #347

Signed-off-by: cspargo <colinspargo@gmail.com>
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.04%. Comparing base (0f21bef) to head (2842ef1).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #348   +/-   ##
=======================================
  Coverage   49.04%   49.04%           
=======================================
  Files           7        7           
  Lines         891      891           
=======================================
  Hits          437      437           
  Misses        412      412           
  Partials       42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tekenstam tekenstam self-assigned this Sep 18, 2023
@tekenstam tekenstam merged commit affac34 into keikoproj:master Apr 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrade never completes if ASG size is 0
4 participants