Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multi-arch support and delete docker-build step from CI #356

Merged
merged 2 commits into from
Jul 15, 2023
Merged

Fix multi-arch support and delete docker-build step from CI #356

merged 2 commits into from
Jul 15, 2023

Conversation

shreyas-badiger
Copy link
Collaborator

@shreyas-badiger shreyas-badiger commented Jul 15, 2023

Following changes included in the PR:

  • There is no need to do a local docker-build step as we are already running a make test step.
  • Update go version in the Dockerfile to 1.17
  • Include additional variables TARGETOS, TARGETARCH
  • Include QEMU step in CI

@codecov
Copy link

codecov bot commented Jul 15, 2023

Codecov Report

Merging #356 (224fe67) into master (204f08a) will not change coverage.
The diff coverage is n/a.

❗ Current head 224fe67 differs from pull request most recent head e69db16. Consider uploading reports for the commit e69db16 to get more accurate results

@@           Coverage Diff           @@
##           master     #356   +/-   ##
=======================================
  Coverage   45.17%   45.17%           
=======================================
  Files           7        7           
  Lines         757      757           
=======================================
  Hits          342      342           
  Misses        376      376           
  Partials       39       39           
Flag Coverage Δ
unittests 45.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: sbadiger <shreyas_badiger@intuit.com>
Signed-off-by: sbadiger <shreyas_badiger@intuit.com>
@shreyas-badiger shreyas-badiger changed the title delete docker-build step Fix multi-arch support and delete docker-build step from CI Jul 15, 2023
@vgunapati vgunapati self-requested a review July 15, 2023 00:55
@shreyas-badiger shreyas-badiger merged commit 5538912 into keikoproj:master Jul 15, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants