Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.0.8 #400

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Release v1.0.8 #400

merged 1 commit into from
Nov 1, 2023

Conversation

shreyas-badiger
Copy link
Collaborator

[v1.0.8] - 2023-10-30

@shreyas-badiger shreyas-badiger requested review from a team as code owners October 30, 2023 04:59
Signed-off-by: sbadiger <shreyas_badiger@intuit.com>
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #400 (90dcd3b) into master (e4a79bf) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #400   +/-   ##
=======================================
  Coverage   39.09%   39.09%           
=======================================
  Files           7        7           
  Lines         931      931           
=======================================
  Hits          364      364           
  Misses        540      540           
  Partials       27       27           
Flag Coverage Δ
unittests 39.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vgunapati vgunapati merged commit cb0ba72 into keikoproj:master Nov 1, 2023
4 checks passed
shreyas-badiger added a commit that referenced this pull request Dec 5, 2023
* early-cordon nodes

Signed-off-by: sbadiger <shreyas_badiger@intuit.com>

* early cordon

Signed-off-by: sbadiger <shreyas_badiger@intuit.com>

* include context in cordon and drain functions

* cordon only drifted instances

* add unit tests

* Update aws-sdk-go-cache to v0.0.2 (#399)

Signed-off-by: Todd Ekenstam <Todd_Ekenstam@intuit.com>
Signed-off-by: sbadiger <shreyas_badiger@intuit.com>

* Process drain-failure nodes at the end (#394)

* Process drain-failures at the end
Signed-off-by: ssheladiya <siddharth_sheladiya@intuit.com>
Signed-off-by: sbadiger <shreyas_badiger@intuit.com>

* early-cordon nodes

Signed-off-by: sbadiger <shreyas_badiger@intuit.com>

* early cordon

Signed-off-by: sbadiger <shreyas_badiger@intuit.com>

* include context in cordon and drain functions

Signed-off-by: sbadiger <shreyas_badiger@intuit.com>

* Release v1.0.8 (#400)

Signed-off-by: sbadiger <shreyas_badiger@intuit.com>

* cordon only drifted instances

Signed-off-by: sbadiger <shreyas_badiger@intuit.com>

* add unit tests

Signed-off-by: sbadiger <shreyas_badiger@intuit.com>

* resolve merge conflicts

* update go.sum

* resolve test errors

* remove cordon as upgrade strategy

* remove space

* improve test coverage

* improve code coverage

* remove redundant code

* remove unused imports

* Update controllers/providers/kubernetes/nodes.go

Co-authored-by: Venkata Gunapati <gvsukumar@gmail.com>

* uncordon the nodes

* error handling for uncordoning

* add tests

* handle uncordon scenario properly

* Update controllers/providers/kubernetes/nodes.go

Co-authored-by: Venkata Gunapati <gvsukumar@gmail.com>

* fix typo

* fix lint errors

* default the feature to false

---------

Signed-off-by: sbadiger <shreyas_badiger@intuit.com>
Signed-off-by: Todd Ekenstam <Todd_Ekenstam@intuit.com>
Co-authored-by: Todd Ekenstam <3845995+tekenstam@users.noreply.github.com>
Co-authored-by: Siddharth Sheladiya <130721367+ssheladiya@users.noreply.github.com>
Co-authored-by: Venkata Gunapati <gvsukumar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants