Skip to content

Commit

Permalink
Improve Lighthouse scores
Browse files Browse the repository at this point in the history
Lighthouse scores in Accessibility and SEO went from 78, 83 to 98, 90.
Added aria-label to scroll to top button in +layout.svelte. Title
element added to app.html. Main.svelte td elements changed to th.
  • Loading branch information
keith-flynn committed Oct 18, 2023
1 parent e335290 commit 82146a2
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
1 change: 1 addition & 0 deletions src/app.html
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
<html lang="en">
<head>
<meta charset="utf-8" />
<title>Keith Flynn | Developer Portfolio</title>
<script src="https://cdnjs.cloudflare.com/ajax/libs/particles.js/2.0.0/particles.min.js"
integrity="sha512-Kef5sc7gfTacR7TZKelcrRs15ipf7+t+n7Zh6mKNJbmW+/RRdCW9nwfLn4YX0s2nO6Kv5Y2ChqgIakaC6PW09A=="
crossorigin="anonymous" referrerpolicy="no-referrer"></script>
Expand Down
8 changes: 4 additions & 4 deletions src/components/Main.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -100,28 +100,28 @@
</thead>
<tbody>
<tr class="border-b border-solid border-slate-200">
<td class="border-r border-solid border-white pl-4 pr-8 py-4 font-semibold text-sm whitespace-nowrap">Dedication</td>
<th class="border-r border-solid border-white pl-4 pr-8 py-4 font-semibold text-sm whitespace-nowrap">Dedication</th>
<td><i class="fa-solid fa-check text-slate-500"></i></td>
<td><i class="fa-solid fa-xmark text-slate-500"></i></td>
<td><i class="fa-solid fa-check text-slate-500"></i></td>
<td><i class="fa-solid fa-check text-green-500"></i></td>
</tr>
<tr class="border-b border-solid border-slate-200">
<td class="border-r border-solid border-white pl-4 pr-8 py-4 font-semibold text-sm whitespace-nowrap">Critical Thought</td>
<th class="border-r border-solid border-white pl-4 pr-8 py-4 font-semibold text-sm whitespace-nowrap">Critical Thought</th>
<td><i class="fa-solid fa-check text-slate-500"></i></td>
<td><i class="fa-solid fa-check text-slate-500"></i></td>
<td><i class="fa-solid fa-xmark text-slate-500"></i></td>
<td><i class="fa-solid fa-check text-green-500"></i></td>
</tr>
<tr class="border-b border-solid border-slate-200">
<td class="border-r border-solid border-white pl-4 pr-8 py-4 font-semibold text-sm whitespace-nowrap">Interpersonal Skills</td>
<th class="border-r border-solid border-white pl-4 pr-8 py-4 font-semibold text-sm whitespace-nowrap">Interpersonal Skills</th>
<td><i class="fa-solid fa-xmark text-slate-500"></i></td>
<td><i class="fa-solid fa-xmark text-slate-500"></i></td>
<td><i class="fa-solid fa-xmark text-slate-500"></i></td>
<td><i class="fa-solid fa-check text-green-500"></i></td>
</tr>
<tr class="border-b border-solid border-slate-200">
<td class="border-r border-solid border-white pl-4 pr-8 py-4 font-semibold text-sm whitespace-nowrap">Programming Ability</td>
<th class="border-r border-solid border-white pl-4 pr-8 py-4 font-semibold text-sm whitespace-nowrap">Programming Ability</th>
<td><i class="fa-solid fa-xmark text-slate-500"></i></td>
<td><i class="fa-solid fa-check text-slate-500"></i></td>
<td><i class="fa-solid fa-check text-slate-500"></i></td>
Expand Down
2 changes: 1 addition & 1 deletion src/routes/+layout.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
? "opacity-full pointer-events-auto"
: "pointer-events-none opacity-0"
)}>
<button on:click={goTop} class="ml-auto rounded-full bg-slate-900 text-violet-400 px-3 sm:px-4 hover:bg-slate-800 cursor-pointer aspect-square grid place-items-center">
<button on:click={goTop} class="ml-auto rounded-full bg-slate-900 text-violet-400 px-3 sm:px-4 hover:bg-slate-800 cursor-pointer aspect-square grid place-items-center" aria-label="Scroll to top">
<i class="fa-solid fa-arrow-up" />
</button>
</div>
Expand Down

0 comments on commit 82146a2

Please sign in to comment.