Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triton translator only works through PAPI #183

Open
GreatGoal0 opened this issue Aug 22, 2023 · 1 comment
Open

Triton translator only works through PAPI #183

GreatGoal0 opened this issue Aug 22, 2023 · 1 comment
Labels
bug Something isn't working priority: moderate

Comments

@GreatGoal0
Copy link

Describe the bug

When using the triton translate placeholder it does not return the correct value, it simply appears as text in the placeholder
[lang][/lang]

To Reproduce

When using the placeholder in CrossplatForms

Expected behaviour

Let the placeholder work

Screenshots / Videos

https://discord.com/channels/853331530004299807/929122730622726174/1143650305083445308

Server Version and Plugins

No response

Geyser Dump

No response

CrossplatForms Version

Version 1.5.0 build 40 commit 3dcb802

Additional Context

Quick fix please <3

@Konicai
Copy link
Member

Konicai commented Aug 29, 2023

Triton mainly operates on the packet level, but only Java Edition packets.

Geyser generally converts Java packets to Bedrock packets. When Geyser receives the Java packet, Triton will have already done its work.

If Geyser sends a Bedrock packet that was not a result of Java packet translation, Triton will never kick in. For example, Bedrock forms.

The reason that /papi parse works with Triton placeholders (the [lang] format) doesn't really have anything to do with papi, and moreso with the fact that it results in a Java packet being sent.

You can use PAPI to handle the translations though, as described here: https://triton.rexcantor64.com/concepts/placeholderapi.html
That should allow Triton to be used on bedrock forms.

I can add direct support for actual Triton placeholders at a later time so that translation arguments are better supported, as described by that page.

@Konicai Konicai changed the title Bug placeholder [Triton translate] Triton translator only works through PAPI Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: moderate
Projects
None yet
Development

No branches or pull requests

2 participants