build: migrate eslint config to flat style #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intcreator
force-pushed
the
intcreator/eslint-config
branch
from
5e7f069
to
9dd53d6
Compare
intcreator
changed the title
|
looks like this won't be able to be merged until we drop support for Node v16 edit: I was able to support Node v16 by downgrading typescript-eslint |
intcreator
force-pushed
the
intcreator/eslint-config
branch
from
9dd53d6
to
44be35b
Compare
intcreator
force-pushed
the
intcreator/eslint-config
branch
from
bc3f362
to
69ff9e9
Compare
sheerlox
approved these changes
Nov 12, 2024
|
🎉 This PR is included in version 3.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate .eslintrc to esling.config.mjs. Using .mjs so I can use
import(.ts configs are still experimental). Fixed a few lint issues that were easy, changed one new lint rule to a warn since it wasn't caught before.Related Issue
Fixes #899
Motivation and Context
Using the new flat config for Eslint is required for upgrading to 9.0
How Has This Been Tested?
Ran
npm run lintand VS Code Eslint plugin many timesScreenshots (if appropriate):
Types of changes
Checklist:
!after the type/scope in the title (see the Conventional Commits standard).