feat(harmonizer): run guessTypesForRelease always after merging types

kellnerd · Jul 3, 2024 · 58b222f · 58b222f
1 parent e019ddb
commit 58b222f
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 5 deletions.
diff --git a/harmonizer/merge.ts b/harmonizer/merge.ts
@@ -1,5 +1,5 @@
 import { immutableReleaseProperties, immutableTrackProperties } from './properties.ts';
-import { mergeTypes } from './release_types.ts';
+import { guessTypesForRelease, mergeTypes } from './release_types.ts';
 import { cloneInto, copyTo, filterErrorEntries, isFilled, uniqueMappedValues } from '@/utils/record.ts';
 import { similarNames } from '@/utils/similarity.ts';
 import { trackCountSummary } from '@/utils/tracklist.ts';
@@ -128,6 +128,7 @@ export function mergeRelease(
 		// Merge release group types
 		if (sourceRelease.types) {
 			mergedRelease.types = mergeTypes(mergedRelease.types || [], sourceRelease.types);
+			guessTypesForRelease(mergedRelease);
 		}
 
 		// combine availabilities

diff --git a/providers/Bandcamp/mod.ts b/providers/Bandcamp/mod.ts
@@ -10,7 +10,6 @@ import type {
 	Label,
 	LinkType,
 } from '@/harmonizer/types.ts';
-import { guessTypesForRelease } from '@/harmonizer/release_types.ts';
 import { type CacheEntry, MetadataProvider, ReleaseLookup } from '@/providers/base.ts';
 import { DurationPrecision, FeatureQuality, FeatureQualityMap } from '@/providers/features.ts';
 import { parseISODateTime } from '@/utils/date.ts';
@@ -309,7 +308,6 @@ export class BandcampReleaseLookup extends ReleaseLookup<BandcampProvider, Relea
 			});
 		}
 
-		guessTypesForRelease(release);
 		return release;
 	}
 

diff --git a/providers/iTunes/mod.ts b/providers/iTunes/mod.ts
@@ -1,7 +1,6 @@
 import { availableRegions } from './regions.ts';
 import { type CacheEntry, MetadataApiProvider, ReleaseApiLookup } from '@/providers/base.ts';
 import { DurationPrecision, FeatureQuality, FeatureQualityMap } from '@/providers/features.ts';
-import { guessTypesForRelease } from '@/harmonizer/release_types.ts';
 import { parseISODateTime, PartialDate } from '@/utils/date.ts';
 import { isEqualGTIN, isValidGTIN } from '@/utils/gtin.ts';
 
@@ -190,7 +189,6 @@ export class iTunesReleaseLookup extends ReleaseApiLookup<iTunesProvider, Releas
 			info: this.generateReleaseInfo(),
 		};
 
-		guessTypesForRelease(release);
 		return release;
 	}