Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend filter configuration for fast out-of-core processing #27

Open
eackermann opened this issue Oct 26, 2017 · 2 comments
Open

extend filter configuration for fast out-of-core processing #27

eackermann opened this issue Oct 26, 2017 · 2 comments

Comments

@eackermann
Copy link
Collaborator

Currently filter epochs are computed internally, and the API is not properly exposed to allow a user to specify in-core or out-of-core, etc.

In addition, it may be desirable to pass in desired epochs (with index=True) directly to the filter object, so that they won't have to be recomputed every time we want to filter. This approach can also make it simpler to customize the epoch calculation to suit the application needs.

@eackermann
Copy link
Collaborator Author

eackermann commented Oct 26, 2017

As an example, we may want something along the lines of

# compute epochs on giant timestamps object that's too large to process in-core:
epochs = jag.utils.get_contiguous_segments(timestamps, assume_sorted=True, step=1, in-core=False, index=True) 
# filter into some band:
filtered = jag.filtering.filtfilt(data, **params1, epochs=epochs)
# now filter into another band, without having to recompute the epochs
filtered2 = jag.filtering.filtfilt(data, **params2, epochs=epochs)

@jchutrue
Copy link
Collaborator

jchutrue commented Nov 8, 2017

Epochs can be passed into filtfilt_within_epochs_mmap--see first commit on the dev branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants