Better globals #490
Merged
Better globals #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Top-level variables in a module are only hoisted to globals if they're referenced in a function (ie. captured). Since these variables can be referenced as globals from within those functions, there's no need to store them as captures for that function, and the function can effectively be invoked as if it were an ordinary function. Top-level variables that are _not_ referenced in functions are treated effectively as locals within the module's wrapper function. Exported variables (which can only be top-level) are always hoisted to globals.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Top-level variables in a module are only hoisted to globals if they're referenced in a function (ie. captured). Since these variables can be referenced as globals from within those functions, there's no need to store them as captures for that function, and the function can effectively be invoked as if it were an ordinary function. Top-level variables that are not referenced in functions are treated effectively as locals within the module's wrapper function. Exported variables (which can only be top-level) are always hoisted to globals.