Skip to content
This repository has been archived by the owner on May 27, 2021. It is now read-only.

Commit

Permalink
Merge pull request #1 from kensho-technologies/webpack_dir
Browse files Browse the repository at this point in the history
remove . from webpack dir names
  • Loading branch information
Gabriel Altay authored Nov 21, 2020
2 parents ac67fa7 + 6268415 commit f512bb4
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 14 deletions.
24 changes: 12 additions & 12 deletions extension/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
Tested with,

```bash
> npm -v
> npm -v
6.14.8
> node -v
> node -v
v12.19.0
```

Expand All @@ -24,17 +24,17 @@ npm run build

Navigate to `chrome://extensions` in your Chrome browser.
Turn on developer mode using the toggle in the upper right.
Click the `Load unpacked` button in the upper left.
Point the file finder that opens to the `wikiwhatsthis/extension/.webpack.dist` directory (note that this is a hidden directory so you may have to toggle something in your file browser to show hidden files/directories).
Click the `Load unpacked` button in the upper left.
Point the file finder that opens to the `wikiwhatsthis/extension/webpack-dist` directory.
To monitor the loading of the extension click on `Inspect views background page`.
This might crash. If it does, click `Load unpacked` and give it another try.
The background page view should open a pop-up that shows logging messages.
You may see some warning like `DevTools failed to load SourceMap` or sklearn warnings about version mismatch and inconsistent stop words. This is OK.
The background page view should open a pop-up that shows logging messages.
You may see some warning like `DevTools failed to load SourceMap` or sklearn warnings about version mismatch and inconsistent stop words. This is OK.
The last message from extension loading is `reading xbm25.npz`.
Once this is complete, you should see the option `WikiWhatsThis - Suggest` when you right click on highlighted text in your browser. If you do not see this option, try reloading the tab or restarting the browser.
Sometimes you have to right-click and ask for suggestions more than once before it works.
If it does work, you will see a popup of suggested Wikipedia pages.
If you've gotten this far, thank the computer development gods and yourself for being an awesome beta user :)
Once this is complete, you should see the option `WikiWhatsThis - Suggest` when you right click on highlighted text in your browser. If you do not see this option, try reloading the tab or restarting the browser.
Sometimes you have to right-click and ask for suggestions more than once before it works.
If it does work, you will see a popup of suggested Wikipedia pages.
If you've gotten this far, thank the computer development gods and yourself for being an awesome beta user :)



Expand All @@ -45,6 +45,6 @@ If you've gotten this far, thank the computer development gods and yourself for
| | |
| :--------------- | :-------------------------------------------------- |
| `npm start` | 🔨 and 👀 files to the `.webpack.build` directory |
| `npm run build` | 🔨 the 📦 extension to the `.webpack.dist` directory. |
| `npm start` | 🔨 and 👀 files to the `webpack-build` directory |
| `npm run build` | 🔨 the 📦 extension to the `webpack-dist` directory. |
| `npm run update` | Download the latest models and pyodide packages. |
4 changes: 2 additions & 2 deletions extension/webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ const IS_DEV = process.env.NODE_ENV !== 'production';
const ROOT_PATH = path.join(__dirname);
const PATHS = {
ROOT: ROOT_PATH,
OUT: `${ROOT_PATH}/.webpack.${IS_DEV ? 'build' : 'dist'}`,
DIST: `${ROOT_PATH}/.webpack.dist`,
OUT: `${ROOT_PATH}/webpack-${IS_DEV ? 'build' : 'dist'}`,
DIST: `${ROOT_PATH}/webpack-dist`,
}

const nodeExternals = () => fs.readdirSync('node_modules').reduce((acc, mod) => {
Expand Down

0 comments on commit f512bb4

Please sign in to comment.