Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IE support. #20

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add IE support. #20

wants to merge 2 commits into from

Conversation

capy-pl
Copy link

@capy-pl capy-pl commented Nov 12, 2018

Hi, first thanks a lot for building this module. really helped me a lot during my work. I find you didn't support Internet Explorer. Although it doesn't have much user now, it is not a bad idea to support IE.

@Remo
Copy link

Remo commented Feb 13, 2019

Your method ieIE should probably be called isIE

@capy-pl
Copy link
Author

capy-pl commented Feb 14, 2019

Your method ieIE should probably be called isIE

Yes. Good catch. That is a typo.

@tharaka1
Copy link

@kensnyder Is IE support fix added to latest? Still I am getting this issue.

@capy-pl
Copy link
Author

capy-pl commented Jul 12, 2019

@tharaka1 The author seems not to maintain this repo anymore. You can pull the fix from my forked repo.

@tharaka1
Copy link

@capy-pl Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants