Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't show newsletter subscription form for subscribed users #44

Closed
smeijer opened this issue Jul 14, 2021 · 4 comments
Closed

Don't show newsletter subscription form for subscribed users #44

smeijer opened this issue Jul 14, 2021 · 4 comments

Comments

@smeijer
Copy link
Collaborator

smeijer commented Jul 14, 2021

Converted from a note, which stated the following:

If the user is logged in and already on the mailing list, we shouldn't show the newsletter subscription thing. Figure out what to render instead.
@smeijer
Copy link
Collaborator Author

smeijer commented Jul 14, 2021

@kentcdodds, how about showing the user that they're currently subscribed to the newsletter (and with what email), and provide them the option to unsubscribe, right there?

@kentcdodds
Copy link
Owner

I don't mind making it easy for people to unsubscribe, but I'm not a fan of directly inviting it so prominently either 😅

@kentcdodds
Copy link
Owner

Maybe it should just show "you're subscribed" and "manage your subscription" which will link them to what we build for #59

@kentcdodds
Copy link
Owner

This is implemented "well enough" for now (I just hide it 🤷‍♂️)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@smeijer @kentcdodds