Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.2.0 #57

Merged
merged 42 commits into from
Oct 22, 2023
Merged

Version 1.2.0 #57

merged 42 commits into from
Oct 22, 2023

Conversation

mstieranka
Copy link
Collaborator

@mstieranka mstieranka commented Oct 20, 2023

Fixes #54 , #56 .

Also includes many new things:

  • Change from node.js / npm to bun (including improved build process)
  • TypeScript support (for now with many checks off to make migrating faster)
  • Svelte support - used in new reworked Options page
  • Splitting end.js into separate files (no more 1000+ lines of code!)
  • Fixed automatic theme so that it can now be released
  • Improved Courses page retrieval
  • Fixed favicon not changing
  • All code is now formatted using Prettier, ESLint and Stylelint are now used for linting of TS/JS and CSS respectively
  • Updated Chrome manifest to v3, including a fancy new permissions page

Next steps:

  • Verify that everything works (I have no active subjects, only ones from past years)
  • Get Firefox and Chrome signing privileges from @keombre to publish new proper update
  • Rebase and clean up the commit history (squash bugfixes etc.)

TODO at some later point (maybe next versions):

  • Some refactors and reworks (see TODO tags)
  • Removals of deprecated functions (e.g. String.prototype.substr)
  • Include highlight.js as npm package instead of directly
  • Maybe even code splitting (so that each page is in its own .js file, thus loading the page faster)

@mstieranka mstieranka self-assigned this Oct 20, 2023
src/content/Course.ts Fixed Show fixed Hide fixed
src/content/Course.ts Fixed Show fixed Hide fixed
src/content/Course.ts Fixed Show fixed Hide fixed
src/content/Logged.ts Fixed Show fixed Hide fixed
src/content/Course.ts Fixed Show fixed Hide fixed
src/content/Logged.ts Fixed Show fixed Hide fixed
@mstieranka mstieranka linked an issue Oct 20, 2023 that may be closed by this pull request
@mstieranka

This comment was marked as outdated.

@keombre
Copy link
Owner

keombre commented Oct 20, 2023

@mstieranka You should now have hopefully all relefant info/keys in your mailbox. Access rights for Chrome Web Store were also updated.

Good luck with the release and happy ProgTesting 😉

I have no active subjects, only ones from past years

Try and ask Mr. Vagner for a testing account. He was always very helpful and even added some internal API endpoints used only by this extension.

}

static getLinksFromHTML(text, href) {
text = text.replace(/<script[^>]*>([\S\s]*?)<\/script>/gim, "");

Check failure

Code scanning / CodeQL

Incomplete multi-character sanitization High

This string may still contain
<script
, which may cause an HTML element injection vulnerability.
}

static getLinksFromHTML(text, href) {
text = text.replace(/<script[^>]*>([\S\s]*?)<\/script>/gim, "");

Check failure

Code scanning / CodeQL

Bad HTML filtering regexp High

This regular expression does not match script end tags like </script >.
elems.forEach((e) => {
const node = document.createElement("a");
node.href = e.link;
node.innerHTML = `<i>${e.subject}</i> Nová úloha:<br /><b>${e.name}</b>`;

Check warning

Code scanning / CodeQL

DOM text reinterpreted as HTML Medium

DOM text
is reinterpreted as HTML without escaping meta-characters.
DOM text
is reinterpreted as HTML without escaping meta-characters.
@mstieranka mstieranka merged commit 539f57f into stable Oct 22, 2023
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to access current progtests Code review not clickable when theme is changed
2 participants