Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 docs #187

Closed
wants to merge 6 commits into from
Closed

V2 docs #187

wants to merge 6 commits into from

Conversation

Sonichigo
Copy link
Member

Pull Request Template

Description

Please include a summary of the change. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Additional Context (Please include any Screenshots/gifs if relevant)

...

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added corresponding tests.
  • Any dependent changes have been merged and published in downstream modules.

Animesh Pathak added 2 commits June 19, 2023 11:30
Signed-off-by: Animesh Pathak <sonichigi@Animeshs-MacBook-Air.local>
Signed-off-by: Animesh Pathak <sonichigi@Animeshs-MacBook-Air.local>
@Sonichigo Sonichigo added documentation Improvements or additions to documentation enhancement New feature or request labels Jul 31, 2023
@Sonichigo Sonichigo self-assigned this Jul 31, 2023
@Sonichigo Sonichigo requested a review from nehagup as a code owner July 31, 2023 05:12
Copy link
Member

@nehagup nehagup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Putting it on hold since the instructions for installation are pending

Signed-off-by: Animesh <kurosakiichigo.songoku@gmail.com>
@Sonichigo Sonichigo requested a review from nehagup August 16, 2023 07:05
Copy link
Member

@nehagup nehagup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add instructions for Native and Docker installations for each supported OS respectively.

Signed-off-by: Animesh <kurosakiichigo.songoku@gmail.com>
@nehagup
Copy link
Member

nehagup commented Sep 8, 2023

Closing this for the new duplicate PR.

@nehagup nehagup closed this Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants