Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added meta-data and json-ld structured data #194

Conversation

ganeshrevadi
Copy link
Contributor

Pull Request Template

Description

Please include a summary of the change. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes (keploy/keploy#803)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • This change requires a documentation update.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added corresponding tests.
  • Any dependent changes have been merged and published in downstream modules.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you and congratulations 🎉 for opening your very first pull request in keploy

Copy link
Member

@nehagup nehagup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ganeshrevadi Thanks for the PR.

There are unnecessary linting changes like replacing '' with "" that are not relevant to this PR.

docusaurus.config.js Outdated Show resolved Hide resolved
docusaurus.config.js Outdated Show resolved Hide resolved
Signed-off-by: ganeshrevadi <ganeshrevadi16@gmail.com>
@ganeshrevadi ganeshrevadi force-pushed the ganeshrevadi/add_meta-data_to_keploy_docs branch from ce8d6e6 to e93ff92 Compare September 13, 2023 08:54
@ganeshrevadi
Copy link
Contributor Author

@ganeshrevadi Thanks for the PR.

There are unnecessary linting changes like replacing '' with "" that are not relevant to this PR.

I have made the changes !

Copy link
Member

@nehagup nehagup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ganeshrevadi there are still listing changes like - "" replaced with '' which are not related to this PR. Can you please revert those back and make the necessary changes only?

@ganeshrevadi
Copy link
Contributor Author

@ganeshrevadi there are still listing changes like - "" replaced with '' which are not related to this PR. Can you please revert those back and make the necessary changes only?
Hey @nehagup ! I have created a new PR for the following changes
(#203)

@ganeshrevadi
Copy link
Contributor Author

Can this PR be closed?

@Sonichigo
Copy link
Member

Closing this PR since new changes are in PR #203

@Sonichigo Sonichigo closed this Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants