Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vale linting in github pipeline #470

Merged
merged 5 commits into from
Nov 11, 2024
Merged

Conversation

Hermione2408
Copy link
Member

@Hermione2408 Hermione2408 commented Oct 21, 2024

What has changed?

Vale has been integrated for grammar and style checking, which will further improve the consistency and quality of the documentation. Ensuring the docs are free from errors will help Vale operate more effectively, making future updates smoother and maintaining high documentation standards.

Closes - keploy/keploy#2363

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Documentation update (if none of the other choices apply).

How Has This Been Tested?

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.

Signed-off-by: Hermione Dadheech <hermionedadheech@gmail.com>
Signed-off-by: Hermione Dadheech <hermionedadheech@gmail.com>
Signed-off-by: Hermione Dadheech <hermionedadheech@gmail.com>
Signed-off-by: Hermione Dadheech <hermionedadheech@gmail.com>
@Hermione2408 Hermione2408 self-assigned this Oct 22, 2024
Copy link
Member

@Sonichigo Sonichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Hermione Dadheech <hermionedadheech@gmail.com>
@Hermione2408 Hermione2408 merged commit 6cc69a8 into main Nov 11, 2024
1 check passed
@Hermione2408 Hermione2408 deleted the feat-add-vale-linting branch November 11, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants