Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added bun installation, new docker-network, and mentioned error messages #477

Merged
merged 3 commits into from
Nov 6, 2024

Conversation

trivedi-khushi
Copy link
Contributor

What has changed?

Please include a summary of the change.

This PR Resolves #(issue)

Type of change

Please delete options that are not relevant.

  • Documentation update (if none of the other choices apply).

How Has This Been Tested?

Please run npm run build and npm run serve to check if the changes are working as expected. Please include screenshots of the output of both the commands. Add screenshots/gif of the changes if possible.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.

Added two more steps before the first limac command mentioned
-install homebrew
-install lima

Signed-off-by: Khushi Trivedi <76205733+trivedi-khushi@users.noreply.github.com>
-added installation of bun
-added potential error message 

Signed-off-by: Khushi Trivedi <76205733+trivedi-khushi@users.noreply.github.com>
Creating new docker network after installing bun dependencies.

Signed-off-by: Khushi Trivedi <76205733+trivedi-khushi@users.noreply.github.com>
@trivedi-khushi trivedi-khushi changed the title Added installation of Bun and it's error message Added bun installation, new docker-network, and mentioned error messages Nov 4, 2024
@Sonichigo Sonichigo self-requested a review November 6, 2024 08:44
Copy link
Member

@Sonichigo Sonichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sonichigo Sonichigo merged commit 1892fd0 into keploy:main Nov 6, 2024
3 of 5 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 6, 2024
…ges (#477)

* Update mac-linux.md

Added two more steps before the first limac command mentioned
-install homebrew
-install lima

Signed-off-by: Khushi Trivedi <76205733+trivedi-khushi@users.noreply.github.com>

* Update samples-bunjs.md

-added installation of bun
-added potential error message

Signed-off-by: Khushi Trivedi <76205733+trivedi-khushi@users.noreply.github.com>

* Creating new docker-network in file samples-bunjs.md

Creating new docker network after installing bun dependencies.

Signed-off-by: Khushi Trivedi <76205733+trivedi-khushi@users.noreply.github.com>

---------

Signed-off-by: Khushi Trivedi <76205733+trivedi-khushi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants