From 4e3d31fe3f567dbba49c54bb96bce4fa44400882 Mon Sep 17 00:00:00 2001 From: Sarthak160 Date: Wed, 6 Dec 2023 05:58:42 +0000 Subject: [PATCH] feat: add hibernate dialects for mysql if user has not set by default Signed-off-by: Sarthak160 --- .../main/java/io/keploy/advice/ksql/RegisterDriverAdvice.java | 1 + .../io/keploy/advice/ksql/RegisterDriverAdvice_Interceptor.java | 1 + integration/src/main/java/io/keploy/ksql/KDatabaseMetaData.java | 1 + 3 files changed, 3 insertions(+) diff --git a/agent/src/main/java/io/keploy/advice/ksql/RegisterDriverAdvice.java b/agent/src/main/java/io/keploy/advice/ksql/RegisterDriverAdvice.java index 6e1003ea..2307be3c 100644 --- a/agent/src/main/java/io/keploy/advice/ksql/RegisterDriverAdvice.java +++ b/agent/src/main/java/io/keploy/advice/ksql/RegisterDriverAdvice.java @@ -26,6 +26,7 @@ public static void enterMethod(@Advice.Origin Method method, @Advice.Argument(va KDriver.Dialect = "org.hibernate.dialect.PostgreSQLDialect"; break; case "com.mysql.cj.jdbc.Driver": + case "com.mysql.jdbc.Driver": KDriver.Dialect = "org.hibernate.dialect.MySQLDialect"; break; case "oracle.jdbc.driver.OracleDriver": diff --git a/agent/src/main/java/io/keploy/advice/ksql/RegisterDriverAdvice_Interceptor.java b/agent/src/main/java/io/keploy/advice/ksql/RegisterDriverAdvice_Interceptor.java index ffa4c679..fe8d314d 100644 --- a/agent/src/main/java/io/keploy/advice/ksql/RegisterDriverAdvice_Interceptor.java +++ b/agent/src/main/java/io/keploy/advice/ksql/RegisterDriverAdvice_Interceptor.java @@ -33,6 +33,7 @@ public static String execute(@SuperCall Callable client, @Origin Method KDriver.Dialect = "org.hibernate.dialect.PostgreSQLDialect"; break; case "com.mysql.cj.jdbc.Driver": + case "com.mysql.jdbc.Driver": KDriver.Dialect = "org.hibernate.dialect.MySQLDialect"; break; case "oracle.jdbc.driver.OracleDriver": diff --git a/integration/src/main/java/io/keploy/ksql/KDatabaseMetaData.java b/integration/src/main/java/io/keploy/ksql/KDatabaseMetaData.java index 9546a00c..c5cf0b36 100644 --- a/integration/src/main/java/io/keploy/ksql/KDatabaseMetaData.java +++ b/integration/src/main/java/io/keploy/ksql/KDatabaseMetaData.java @@ -82,6 +82,7 @@ public String getDatabaseProductName() throws SQLException { case "org.postgresql.Driver": return "PostgreSQL"; case "com.mysql.cj.jdbc.Driver": + case "com.mysql.jdbc.Driver": return "MySQL"; case "org.h2.Driver": return "H2";