Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hyperbolic ops #634

Merged
merged 6 commits into from
Jul 30, 2023
Merged

Add hyperbolic ops #634

merged 6 commits into from
Jul 30, 2023

Conversation

FayazRahman
Copy link
Contributor

@google-cla
Copy link

google-cla bot commented Jul 28, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Looking good 👍

@fchollet
Copy link
Member

Please check out the test failures -- to format the code you can use sh shell/format.sh

@FayazRahman
Copy link
Contributor Author

FayazRahman commented Jul 28, 2023

Pushed fixes. Just noticed there is a tanh in ops.nn as well, I'm wondering if something needs to be done about that.

@fchollet
Copy link
Member

Just noticed there is a tanh in ops.nn as well, I'm wondering if something needs to be done about that.

Typically it will be accessed from ops. I think we should remove the one from ops.nn and keep the numpy one.

Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍

@fchollet
Copy link
Member

Still seems to be some test failures.

@FayazRahman
Copy link
Contributor Author

Those tests are passing for me on all backends though.

@fchollet fchollet merged commit f1652d1 into keras-team:main Jul 30, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hyperbolic functions missing
2 participants