-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hyperbolic ops #634
Add hyperbolic ops #634
Conversation
FayazRahman
commented
Jul 28, 2023
- Adds hyperbolic ops to ops/numpy
- Closes hyperbolic functions missing #612
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! Looking good 👍
Please check out the test failures -- to format the code you can use |
Pushed fixes. Just noticed there is a |
Typically it will be accessed from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 👍
Still seems to be some test failures. |
…ops/hyperbolic
Those tests are passing for me on all backends though. |