Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the missing weight name for Dense layer #648

Merged
merged 2 commits into from
Aug 1, 2023
Merged

Fix the missing weight name for Dense layer #648

merged 2 commits into from
Aug 1, 2023

Conversation

qlzh727
Copy link
Member

@qlzh727 qlzh727 commented Jul 31, 2023

No description provided.

@fchollet
Copy link
Member

Thanks for the PR! This seems to make the test test_TensorBoard_weight_images fail -- perhaps we need to change some golden value.

@qlzh727
Copy link
Member Author

qlzh727 commented Jul 31, 2023

yea, updated test. I think the golden value in the test is not correct, which is introduced because of the missing variable name for dense lay er.

fchollet
fchollet approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fchollet fchollet merged commit b2c156f into main Aug 1, 2023
6 checks passed
@qlzh727 qlzh727 deleted the Dense-weight-name-fix branch August 1, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fchollet fchollet fchollet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qlzh727 @fchollet