Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to turn on/off ingress #22

Merged
merged 6 commits into from
Nov 27, 2024

Conversation

cedricve
Copy link
Member

@cedricve cedricve commented Nov 27, 2024

Description

Pull Request Description: Add Possibility to Turn On/Off Ingress

Motivation

The primary motivation behind this change is to provide greater flexibility and control over the deployment configurations of the Kerberos Hub application. By introducing the ability to enable or disable ingress, users can customize their deployment environments more precisely to meet their specific needs. This is particularly useful for scenarios where ingress is not required or where alternative networking configurations are preferred.

Changes Introduced

  1. Ingress Toggle in Helm Charts:

    • Updated the Helm chart templates (hub-api.yaml, hub-frontend-demo.yaml, hub-frontend.yaml) to conditionally include ingress configurations based on the ingress value in values.yaml.
    • This conditional logic allows users to enable or disable ingress by setting the appropriate values in their Helm chart configurations.
  2. CI Workflow Updates:

    • Added new GitHub Actions workflows (kind-cloud.yaml, microk8s.yaml) to deploy the application on Kind and MicroK8s clusters, respectively.
    • These workflows include steps to install the necessary dependencies, create Kubernetes clusters, and deploy the Kerberos Hub Helm chart.
  3. Values Configuration:

    • Modified values.yaml to include non-placeholder default values for various configuration parameters such as rabbitmq, kafka, kerberoshub, and oauth2Proxy. This ensures that the Helm chart can be deployed without requiring immediate user intervention to replace placeholder values.
  4. Chart Version Bump:

    • Incremented the chart version from 0.73.0 to 0.74.0 to reflect the new feature addition and updates.

Benefits

  • Flexibility: Users can now choose whether to enable ingress based on their deployment requirements, allowing for more tailored and efficient configurations.
  • Improved CI/CD: The new workflows for Kind and MicroK8s ensure that the application is tested across different Kubernetes environments, enhancing the robustness and reliability of the deployment process.
  • User-Friendly Defaults: Providing non-placeholder default values in values.yaml makes the initial setup and deployment process smoother and less error-prone for users.

Overall, these changes enhance the configurability, deployment flexibility, and user experience of the Kerberos Hub project.

@cedricve cedricve merged commit d8a29e3 into main Nov 27, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant