Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to 0.64.0 + change ingress names #7

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Conversation

cedricve
Copy link
Member

@cedricve cedricve commented Oct 30, 2024

Pull Request Description

Title: Update to 0.64.0 + Change Ingress Names

Motivation and Improvement:

  1. Version Update:

    • Chart Version: Incremented the chart version from 0.63.0 to 0.64.0 in charts/hub/Chart.yaml. This follows Semantic Versioning and reflects the updates and improvements made in this release. Keeping the version updated ensures clarity in tracking changes and deploying the correct version.
  2. Ingress Name Changes:

    • Purpose: The ingress names have been made more descriptive to avoid confusion and potential conflicts.
    • Changes:
      • In charts/hub/templates/kerberos-hub/hub-api.yaml: Changed the ingress name from oauth2-proxy to oauth2-proxy-api.
      • In charts/hub/templates/kerberos-hub/hub-frontend-demo.yaml: Changed the ingress name from oauth2-proxy to oauth2-proxy-frontend-demo.
      • In charts/hub/templates/kerberos-hub/hub-frontend.yaml: Changed the ingress name from oauth2-proxy to oauth2-proxy-frontend.
    • Benefits: These changes make the ingress names more specific to their respective components, improving readability and maintainability of the code. It also helps in better management and debugging of ingress resources in the Kubernetes environment.

Overall, these changes enhance the project's version management and improve the clarity and specificity of ingress resource naming, contributing to a more robust and maintainable codebase.

@cedricve cedricve merged commit 7631b10 into main Oct 30, 2024
2 checks passed
@cedricve cedricve self-assigned this Oct 30, 2024
@cedricve cedricve deleted the feature/add-oauth-to-api branch October 30, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant