-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Access to flag_to_string function #133
Comments
the thing is, that function was meant only for debug purposes to convert the uint8_t enum values into the corresponding technique as a string because of how annoying it was for me to do that manually. I also don't really want the I'm also not really keen with the idea of adding boost, because that's going to require people to download it, making the library not ready out of the box anymore, which I highly value. And plus I'd say it's not worth sacrificing the default compatibility of the lib for all systems by adding boost as a requirement just for a debug feature. So that's also a no-go for me again. I can definitely make Thanks for the recommendation though! |
@D00Movenok done: #134 I removed the "VM::" parts in the output because I assumed that was a bit redundant. Let me know if anything else is needed :) |
Hi there!
I'm using your lib with external logging. For nicer logs representation
flag_to_string
function needs to be public.To solve this problem I found two ways:
VM::flag_to_string
, notVM::util::flag_to_string
and make it public;VM::util
structure public.Because it is your project, going to ask you, which one do you prefer? The first one seems better to me. Will PR according to your answer :)
Also it seems that macros from
boost/preprocessor.hpp
(https://stackoverflow.com/a/5094430) may be used to automate the headache of creating such a big switch-case. Is it ok for you, if I'll try to rewrite the func?The text was updated successfully, but these errors were encountered: