Fix VM::ALL, add missing techniques to flag_to_string and replace COUTs with debug(...) #130
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
Thank you for this awesome project. To make it better, I made some bug fixes:
VM::ALL
missedRDTSC
andRDTSC_VMEXIT
techniques, so I've added them;flag_to_string
function missed a lot of new techniques, so I've appended them;cout <<
instead ofdebug(...)
, so now they usedebug(...)
.I hope, 2 first fixes are easy to understand, but the last one needs some explanation: actually, in your lib
debug()
andcore_debug()
macroses can be replaced with end-user's debugging library, so if you usecout
, it won't work.Also I have a question about
VM::ALL
- maybe it also must enableVM::SPOOFABLE
flag, because without it not all techniques are executed?