-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Windows XP build #146
base: main
Are you sure you want to change the base?
Fix Windows XP build #146
Conversation
Fix invalid winevt (not found in Windows XP)
Fixed:
Now I can build it in Visual Studio 2022 for Windows XP (v141_xp) |
I got 'VVM DETECTED' 'HyperVisor' when build for WinXP, i can't fix it :( |
sorry but I'm not sure what you mean. Did the lib detect Hyper-V under WinXP? Also thanks for the PR! But I want to make sure what I'm merging works fine, so I'll merge it later after testing it around |
|
@kernelwernel I run WinXP build under clean Windows 11 and got result "vm == 100% , Microsoft Hyper-V" |
did you receive any information about which techniques were detected? |
How I can get this information? |
maybe you can compile the cli.cpp file on your build, I never compiled anything for Windows XP so I'm really not sure how that would work out. If you can't, I could create another custom debug binary for you like last time |
@kernelwernel I don't know how to compile cli for XP |
Is it possible if you can run either one of these and tell me the output? Would be very helpful, thanks :) 32-bit: https://github.com/kernelwernel/VMAware/actions/runs/10861852604/artifacts/1933007774 |
Normal result, no VM found. But compiled not for XP (for Major version 6 Minor version 0) |
For Windows XP compile possible need to changes in project settings ( for Visual Studio I add '/Zc:strictStrings-' for remove strictStrings compiler option else compile cause error BSTR ) |
Hm. Do you think the errors could be fixable by a few changes to the lib? If there's like a billion errors then I'll probably just add a note in the README that says "add '/Zc:strictStrings-' to your compiler options if you're compiling on Windows XP". I'm not sure how many errors you got, or more importantly WHERE the errors are located, but if it sounds realistic to find a complete fix without having to add that compiler option then I'm definitely willing to find a solution. |
@UnrealKaraulov Is it ok if I merge the PR? I don't want this to be forgotten and left without anything out of it. If you think it's not a good idea yet then let me know. |
This can fix Windows XP build ?