-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display Joined Missions in My Profile page. #31
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kessie2862
Good job so far! I see you put a lot of effort into this project. However, there are some issues that you still need to work on to go to the next project but you are almost there
Highlights
- No linter errors
- Descriptive PR
Required Changes ♻️
After joining a mission, the list of joined missions will be displayed on the 'my profile' page. But when going back to Missions page, the page refreshes and every joined missions will be lost. Check the video attached below.
screen_recording_my_profile_missions.mp4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kessie2862 👋,
Your project is complete! There is nothing else to say other than... it's time to merge it
Congratulations! 🎉
Highlights
Displayed joined missions on my profile page. 👍
No Linter error. 👍
Descriptive PR. 👍
Optional suggestions
Kindly, Do not commit old pieces of code as inline comments as they make your project look messy.
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
This PR adds a new feature to the "
My Profile
" page in the React application. Itfilters
and displays a list of joined missions for the user. The feature utilizes thefilter()
function to retrieve the joined missions from theRedux
store.Changes Made
Profile.js
component to display the joined missions.useSelector
hook fromreact-redux
to access the missions stored in theRedux
state.filter()
method on the missions array to retrieve only the joined missions.No missions joined
." or a list of joined missions based on the length of joinedMissions.profile page
.