Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add style prop to the Form component #292

Closed
Martinnord opened this issue Oct 6, 2018 · 3 comments
Closed

Add style prop to the Form component #292

Martinnord opened this issue Oct 6, 2018 · 3 comments
Assignees

Comments

@Martinnord
Copy link

What

Add a style prop to the Form component.

Why

Since almost every elements has a style prop it would be awesome to see one here as well. It will open up more possibilities when styling your form and maybe speed up UI prototyping.

How

TBA ;-)

@kettanaito
Copy link
Owner

Thanks for pointing this out, @Martinnord.

I would extend the proposal of this issue to ensure props propagation to the <form> component. This could be handled by spreading the custom props before attaching the RAF-specific ones.

I will try to cover this and publish under the next patch release.

@kettanaito
Copy link
Owner

After a short look it became evident why this wasn't implemented as spreading at the very beginning. If we spread all the props from Form onto <form> component, we would propagate our custom props to a common DOM element (props like initialValues, onReset, etc.). This results into error of unknown props, and thus isn't a safe option.

@kettanaito
Copy link
Owner

I have added the support for style prop on the Form component.

However, I have stumbled upon the current CI pipeline not working properly, producing falsy negative results. There will be no new release until #287 is fixed. Thank you for understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants