Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIx output reader #146

Merged
merged 13 commits into from
Aug 14, 2023
Merged

FIx output reader #146

merged 13 commits into from
Aug 14, 2023

Conversation

keurfonluu
Copy link
Owner

@keurfonluu keurfonluu commented Aug 14, 2023

  • Fixed: standard output reader failed to be parse when data contains integer values (e.g., MATERIAL) (fixes TIMBC block  #145).
  • Fixed: some Docker related issues.

Reminders:

  • Run invoke format to make sure the code follows the style guide,
  • Add tests for new features or tests that would have caught the bug that you're fixing,
  • Write detailed docstrings for all functions, classes and/or methods,
  • If adding new functionality, unit test it and add it to the documentation.

@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Patch coverage: 9.09% and project coverage change: -0.09% ⚠️

Comparison is base (e987c44) 90.48% compared to head (54bca99) 90.40%.
Report is 8 commits behind head on master.

❗ Current head 54bca99 differs from pull request most recent head 0a9b4cf. Consider uploading reports for the commit 0a9b4cf to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #146      +/-   ##
==========================================
- Coverage   90.48%   90.40%   -0.09%     
==========================================
  Files          97       97              
  Lines        6148     6147       -1     
==========================================
- Hits         5563     5557       -6     
- Misses        585      590       +5     
Files Changed Coverage Δ
toughio/_run.py 11.76% <0.00%> (-0.94%) ⬇️
toughio/_io/output/tough/_tough.py 79.38% <100.00%> (-1.21%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@keurfonluu keurfonluu merged commit 4671c75 into master Aug 14, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TIMBC block
1 participant