Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add handler for resizing images #58

Closed
kevinanielsen opened this issue Dec 25, 2023 · 5 comments · Fixed by #72
Closed

[Feature] Add handler for resizing images #58

kevinanielsen opened this issue Dec 25, 2023 · 5 comments · Fixed by #72
Assignees
Labels
api Improvements or additions to the api enhancement New feature or request go Language: Go good first issue Good for newcomers

Comments

@kevinanielsen
Copy link
Owner

Is your feature request related to a problem? Please describe.

Currently, no way to resize images when uploading

Describe the solution you'd like

An endpoint to resize an image possibly accepting a body with the following structure.

{
  "filename": "string",
  "width": "number",
  "height": "number",
}

Describe alternatives you've considered

N/A

Additional context

N/A

@kevinanielsen kevinanielsen added enhancement New feature or request good first issue Good for newcomers api Improvements or additions to the api go Language: Go labels Dec 25, 2023
@juroberttyb
Copy link
Contributor

Hi @kevinanielsen, I would like to work on this feature, cloud you assign me this issue?

@juroberttyb
Copy link
Contributor

Also, please help review a small PR here, I would like to help improve other code in future PRs.

@kevinanielsen
Copy link
Owner Author

@juroberttyb You've been assigned - let me know if you need help with anything :)

Sure, I'll take a look at it!

@juroberttyb
Copy link
Contributor

Hi @kevinanielsen, I have created a PR that adds an image resize endpoint. Please consider helping me review the PR. Thanks.

@kevinanielsen kevinanielsen linked a pull request Dec 27, 2023 that will close this issue
8 tasks
@kevinanielsen
Copy link
Owner Author

This issue is now closed. Thanks again for the contribution! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Improvements or additions to the api enhancement New feature or request go Language: Go good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants