refactor: change folder name #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinanielsen
added
docs
|
While changes to the folder structure are needed to use best practices, I don't agree with this folder structure. There should not be definitive backend/ and frontend/ folders. Take a look at the folder structure of https://github.com/pocketbase/pocketbase and their use of the ui/ directory |
|
I understand, we have to see which pattern you want to follow. I'll send some repo: terraform Looking at these examples there really is no backend inside the backend folder |
|
These patterns I like a lot. |
|
Do you want to keep the ui or website? |
|
ui would be best |
* feat: add property 'multiple' to file input * feat: sends multiple documents or images to api * fix: show icon for each file being uploaded * fix: refresh page after uploading all files * chore: add semicolons * fix: cards overflow * chore: add EOF * fix: prevent file name overflow in card Co-authored-by: Kevin Nielsen <keveran@gmail.com> * chore: fix indentation --------- Co-authored-by: Kevin Nielsen <keveran@gmail.com>
* Update handleImageResize.go * fix: successfully typo
kevinanielsen
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code has an error and probably won't run, I need you to do some tests after merging
This code in the
backend/internal/router/router.gopath is giving an error, reason: it is not finding the modulegithub.com/kevinanielsen/go-fast-cdn/frontend.I need you to go into the backend folder and run the command
go get github.com/kevinanielsen/go-fast-cdn/frontendIf you get an error, run thisgo get github.com/kevinanielsen/go-fast-cdn/frontend@development